Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download a single video instead of all videos in a playlist #124

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

deldesir
Copy link
Collaborator

@deldesir deldesir commented Feb 9, 2024

🚀 Pull Request Overview:

This PR ensures a single video is downloaded using its relevant url from all those added to the database by lb tubeadd

📋 Checklist:

  • Tested the changes on Ubuntu 24.04

🐛 Related issue(s): #114, #120

📌 Testing scenarios:

  • Submit a valid playlist URL
  • Observe the sequential progress polling for each download
  • Observe accurate runtime (not 0s) in Runtime column
  • Observe the successful downloads of all videos

Screenshot_20240209-080523

cc @EMG70

Download a single video using its relevant url from all those added to the database by lb tubeadd
@deldesir deldesir added bug Something isn't working enhancement New feature or request labels Feb 9, 2024
@deldesir deldesir requested a review from holta February 9, 2024 07:40
@deldesir deldesir self-assigned this Feb 9, 2024
@holta holta merged commit ac244a8 into iiab:master Feb 9, 2024
@EMG70
Copy link

EMG70 commented Feb 9, 2024

Test PR#124
IIAB-DIAGNOSTICS http://sprunge.us/cPanTU?en
Submit a valid playlist - URL https://www.youtube.com/playlist?list=PL0o_zxa4K1BXr49VZTEyUS5-G8fz0Pt1v

Observe the sequential progress polling for each download ✅
This playlist showed as failed on first top row but sequential progress polling OK as dscribed by @deldesir .All videos downloaded despite failed state at top row.
Screenshot from 2024-02-09 22-56-44
Another test was tried with a different playlist url - https://www.youtube.com/playlist?list=PLqxP5EuGxPneuoIZWovAfOXUVlvlv3SSM,all downloaded without issues.see below.
Screenshot from 2024-02-09 22-57-53

Observe accurate runtime (not 0s) in Runtime column ✅

@EMG70
Copy link

EMG70 commented Feb 9, 2024

A second attempt to download previously failed status url https://www.youtube.com/playlist?list=PL0o_zxa4K1BXr49VZTEyUS5-G8fz0Pt1v resulted in a warning about members only video ..Which I think is not correct output.
Screenshot from 2024-02-09 23-26-10

@deldesir
Copy link
Collaborator Author

deldesir commented Feb 10, 2024

I can't find the failed video among the 11 ones in the Playlist. Could it be hidden? I don't have an answer for now, but I'll keep digging. Thanks for the comprehensive feedback.

Here is the URL of the failed video for context:
https://m.youtube.com/watch?v=JufLGbcXXjY

@EMG70
Copy link

EMG70 commented Feb 10, 2024

The perceived failed message was not a failure to download any part of playlist but just the displayed output at initial download instance (row 1 of first screenshot),the message comes up as failed Task progress should be within range [0,1] see first screenshot.
The url was https://www.youtube.com/playlist?list=PL0o_zxa4K1BXr49VZTEyUS5-G8fz0Pt1v

@deldesir deldesir deleted the deldesir-patch-9 branch July 1, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants