Update to retrieve key metadata #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deldesir
force-pushed
the
deldesir-patch-19
branch
from
3f7e9de
to
5f11662
Compare
This builds upon iiab#142 to progress towards implementing the top 100 feature
|
I tested this PR with this 6-video playlist: https://www.youtube.com/playlist?list=PLqq4LnWs3olVi7-aKmckmhLJd9laC-F8B Before this PR: After this PR: captions, view_count and time_uploaded are updated:
|
|
Is additional testing needed? |
|
I don't think so. It doesn't affect downloading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon #142 to progress towards implementing the top 100 feature. With this PR, metadata like time_uploaded, view_count become available, but they are not used yet.