-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore failed/residual/stuck video downloads: download only newly requested one(s) #147
Conversation
Videos are sorted by views-per-day and limited by MAX_VIDEOS_PER_DOWNLOAD
size and time_uploaded metadata are missing for YouTube Shorts. We don't count them, failed videos too.
…sion Other users might be testing or some videos did not download from a previous session. Focus on the requested video(s).
What is meant by "trailing videos" ? (Thanks for explaining!) |
Videos from another session that were not downloaded or failed for some reason. It might be leftover videos resulting from testing lb-wrapper or from a parallel downloading in case of a multi-user use case. |
Is the new subject line tolerable? (Improve on it if nec!) |
Looks good to me |
Is this PR tested? Is this PR closely related to... ? |
It's being tested right now.
Yes. Additionally, xklb considers the playlist already downloaded, same issue we encountered when redownloading single videos. I will address this with a similar fix, adding a timestamp to every playlist downloaded. I have yet to test a channel to check for this behavior. |
Tested with #151. Ready for merge. |
Should this be merged now? Or better to wait a bit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This works [well] enough.
No description provided.