Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape quotes to fix SyntaxError for RPI [Concatenate instead of using f-string, for Raspberry Pi] #201

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

deldesir
Copy link
Collaborator

@deldesir deldesir commented Jun 24, 2024

Fixes SyntaxError mentioned in #187.

Not tested yet. @nzola can you give this PR a try?

@deldesir deldesir added the bug Something isn't working label Jun 24, 2024
@deldesir deldesir requested a review from holta June 24, 2024 07:05
@deldesir deldesir self-assigned this Jun 24, 2024
@holta
Copy link
Member

holta commented Jun 24, 2024

@EMG70 would you have time to try this PR?

On any RPi 4 or RPi 400, if so!

Instructions:

https://github.com/iiab/calibre-web/wiki#how-do-i-test-a-pull-request-pr-

@EMG70
Copy link

EMG70 commented Jun 24, 2024

@EMG70 would you have time to try this PR?

On any RPi 4 or RPi 400, if so!

Instructions:

https://github.com/iiab/calibre-web/wiki#how-do-i-test-a-pull-request-pr-

I will try shortly and update you.

@EMG70
Copy link

EMG70 commented Jun 24, 2024

SUDO IIAB - DIAGNOSTICS - https://dpaste.com/96JFWQJUU
I tested after running PR#201 script, box/books and 192.168.0.79/books both returned 502 Bad Gateway
20240624_10h40m35s_grim

@deldesir
Copy link
Collaborator Author

Today I learned. Thanks @EMG70. I see what's happening. Next commit will remove the problematic f-string.

@holta
Copy link
Member

holta commented Jun 24, 2024

Today I learned. Thanks @EMG70. I see what's happening. Next commit will remove the problematic f-string.

  • Smoke-tested on Ubuntu 24.04
  • PR will now be merged
  • Needs additional testing after it's merged: can @nzola or @EMG70 fully retest (either fresh install or upgrade on Raspberry Pi!) in the coming 24h ideally?!

@holta holta merged commit 79c8b12 into iiab:master Jun 24, 2024
@holta holta changed the title Escape quotes to fix SyntaxError for RPI Escape quotes to fix SyntaxError for RPI [Concatenate instead of using f-string, for Raspberry Pi] Jun 24, 2024
@EMG70
Copy link

EMG70 commented Jun 24, 2024

I can now access box/books after upgrading.
There is however an xklb warning at the very top of upgrade script.Please see screenshot.
image

@holta
Copy link
Member

holta commented Jun 24, 2024

I personally can't reproduce @EMG70's failure of pipx to install xklb on "Raspberry Pi OS with desktop" — based on Debian 12 "Bookworm" — this all works for me:

sudo -i
apt install pipx
pipx install xklb    # Took about 3-4 minutes

.local/bin/lb --version
.local/pipx/venvs/xklb/bin/yt-dlp --version          # Run this on RasPiOS 12, Debian 12
.local/share/pipx/venvs/xklb/bin/yt-dlp --version    # Run this on recent versions of Ubuntu, and more modern OS's?
pipx upgrade --include-injected xklb

@EMG70 can you try the above commands on a completely fresh / untouched install of Raspberry Pi OS ("Lite" version or "with desktop" version) ?

@EMG70
Copy link

EMG70 commented Jun 24, 2024

A new small size IIAB was installed .
SUDO IIAB-DIAGNOSTICS - https://dpaste.com/E89S7DXN5
IMG_3881

@holta
Copy link
Member

holta commented Jun 24, 2024

@EMG70 looks much better:

Try the "Download to IIAB" button, and let us know how it works!?

@EMG70
Copy link

EMG70 commented Jun 24, 2024

SUDO IIAB-DIAGNOSTICS - https://dpaste.com/64GKBP2GX

Download to IIAB working Ok.
Screenshot 2024-06-24 at 22-47-03 Internet in a Box Tasks

@holta
Copy link
Member

holta commented Jun 24, 2024

Incredible news, thank you @EMG70 !

@nzola
Copy link

nzola commented Jun 30, 2024

@deldesir Just to confirm, YES! Calibre-Web is working on both Pi4 and Pi400. Video downloads are working as well without any problems. BIG thank you! @deldesir
This is for pi4 PUBLISHING TO URL... https://dpaste.com/CQWNGR8BQ
This is for pi400 PUBLISHING TO URL... https://dpaste.com/7QMUUEY8V

@deldesir
Copy link
Collaborator Author

deldesir commented Jul 1, 2024

Thanks a lot @nzola for your feedback. This is good news though continuous battle-testing with different playlists/channels is needed.

@deldesir deldesir deleted the deldesir-patch-51 branch July 1, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants