-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape quotes to fix SyntaxError for RPI [Concatenate instead of using f-string, for Raspberry Pi] #201
Conversation
@EMG70 would you have time to try this PR? On any RPi 4 or RPi 400, if so! Instructions: https://github.com/iiab/calibre-web/wiki#how-do-i-test-a-pull-request-pr- |
I will try shortly and update you. |
SUDO IIAB - DIAGNOSTICS - https://dpaste.com/96JFWQJUU |
Today I learned. Thanks @EMG70. I see what's happening. Next commit will remove the problematic f-string. |
|
I personally can't reproduce @EMG70's failure of pipx to install xklb on "Raspberry Pi OS with desktop" — based on Debian 12 "Bookworm" — this all works for me:
@EMG70 can you try the above commands on a completely fresh / untouched install of Raspberry Pi OS ("Lite" version or "with desktop" version) ? |
A new small size IIAB was installed . |
@EMG70 looks much better: Try the "Download to IIAB" button, and let us know how it works!? |
SUDO IIAB-DIAGNOSTICS - https://dpaste.com/64GKBP2GX |
Incredible news, thank you @EMG70 ! |
@deldesir Just to confirm, YES! Calibre-Web is working on both Pi4 and Pi400. Video downloads are working as well without any problems. BIG thank you! @deldesir |
Thanks a lot @nzola for your feedback. This is good news though continuous battle-testing with different playlists/channels is needed. |
Fixes SyntaxError mentioned in #187.
Not tested yet. @nzola can you give this PR a try?