Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to STDOUT instead of STDERR: scripts/lb-wrapper #92

Closed
wants to merge 1 commit into from

Conversation

deldesir
Copy link
Collaborator

@deldesir deldesir commented Jan 12, 2024

I did not use a clean unit test for PR #88, making it pass with the original lb-wrapper from #86. I did not catch that the specific explicit redirection to STDERR introduced in #87 would prevent capturing lines with "downloading..." in them. So I revert back to the working state with this PR changing

https://github.com/holta/calibre-web/blob/f6c6b738cbf24656ddf867edb2d5de000f6fd6f6/scripts/lb-wrapper#L62C1-L65C7:

eval "${XKLB_FULL_CMD}" \
     > >(while read -r line; do log "Info" "$line"; done) \
     2> >(while read -r line; do log "Warning" "$line" 1>&2; done) &
pid=$!

to

https://github.com/deldesir/calibre-web/blob/09769ef77604bb5998e6a796fea595117173d144/scripts/lb-wrapper#L62C1-L65C7:

eval "${XKLB_FULL_CMD}" \
     > >(while read -r line; do log "Info" "$line"; done) \
     2> >(while read -r line; do log "Warning" "$line"; done) &
pid=$!

@deldesir deldesir added the bug Something isn't working label Jan 12, 2024
@deldesir deldesir self-assigned this Jan 12, 2024
@deldesir deldesir requested a review from holta January 12, 2024 01:45
@deldesir deldesir changed the title Redirect to STDOUT instead of STDERR explicitly: scripts/lb-wrapper Redirect to STDOUT instead of STDERR: scripts/lb-wrapper Jan 12, 2024
@deldesir
Copy link
Collaborator Author

Closed in favor of #93

@deldesir deldesir closed this Jan 12, 2024
@deldesir deldesir deleted the deldesir-revert-to-stdout branch July 1, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant