Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of the CLI tool #40

Merged
merged 18 commits into from
Aug 23, 2023
Merged

Improvement of the CLI tool #40

merged 18 commits into from
Aug 23, 2023

Conversation

zeljkobekcic
Copy link
Contributor

@zeljkobekcic zeljkobekcic commented Jul 5, 2023

This branch moved from the argparse package to the de-facto standard for argument parsing (cobra + viper). We are now able to:

  • generate documentation
  • auto-completion for different shells
  • auto-suggestion on a typo in a command
  • read env as alternative to flag without manually written code
  • provide examples for each command separately and show them in the docs

Everything about the CLI is now in one place.

Furthermore we need to:

  • adapt the ci pipeline to automatically generate the docs and push it to the wiki
  • adapt the builds to include the auto completion in the releases, especially the linux builds such that the users get everything out of the box

zeljkobekcic and others added 7 commits June 7, 2023 11:26
This is the first attempt at using a very established argument parser and cobra as configuration management.

These tools also generate completions for the shell. Can also suggest fixes for incorrectly typed commands
Includes auto-completion generation
Includes documentation generation
Ninja243
Ninja243 previously approved these changes Jul 21, 2023
Copy link
Contributor

@Ninja243 Ninja243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Ninja243 Ninja243 self-assigned this Aug 23, 2023
Don't remove binaries after building them with goreleaser, actually register skip-tls-verification option
@zeljkobekcic zeljkobekcic merged commit 8675811 into main Aug 23, 2023
7 checks passed
@zeljkobekcic zeljkobekcic deleted the improvement-cli-tool branch August 23, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants