fix linting and pipelines

.github/workflows/build.yaml

@@ -41,12 +41,12 @@ jobs:
               dep ensure
           fi
       - name: Build
-        run: go build -v -o otc-auth .
+        run: go build -v -o waf-cert-uploader
       - name: Upload the built binary executable for testing
         uses: actions/upload-artifact@v2
         with:
           name: build
-          path: otc-auth
+          path: waf-cert-uploader
   test:
     needs: build
     runs-on: ubuntu-latest

.github/workflows/release.yaml

@@ -30,5 +30,5 @@ jobs:
         with:
           push: true
           tags: |
-            ghcr.io/iits-consulting/otc-auth:latest
-            ghcr.io/iits-consulting/otc-auth:${{ env.RELEASE_VERSION }}
+            ghcr.io/iits-consulting/waf-cert-uploader:latest
+            ghcr.io/iits-consulting/waf-cert-uploader:${{ env.RELEASE_VERSION }}

controller/controller.go

@@ -54,11 +54,11 @@ func HandleUploadCertToWaf(writer http.ResponseWriter, httpRequest *http.Request
 		return
 	}
 
-	writeResponseObjectToConnection(writer, err, *responseBytes)
+	writeResponseObjectToConnection(writer, *responseBytes)
 }
 
-func writeResponseObjectToConnection(writer http.ResponseWriter, err error, responseBytes []byte) {
-	_, err = writer.Write(responseBytes)
+func writeResponseObjectToConnection(writer http.ResponseWriter, responseBytes []byte) {
+	_, err := writer.Write(responseBytes)
 	if err != nil {
 		log.Println("http reply failed", err)
 	}

main.go

@@ -11,7 +11,6 @@ import (
 )
 
 type ServerParameters struct {
-	port     int    // webhook server port
 	certFile string // path to the x509 certificate for https
 	keyFile  string // path to the x509 private key matching `CertFile`
 }

service/waf_client_service.go

@@ -111,11 +111,29 @@ var getAuthOptionsFromMountedSecret = func() error {
 		return errors.New("environment variable for the credentials mount path was not found")
 	}
 	username, err := os.ReadFile(credentialsMountPath + "username")
+	if err != nil {
+		return err
+	}
 	password, err := os.ReadFile(credentialsMountPath + "password")
+	if err != nil {
+		return err
+	}
 	accessKey, err := os.ReadFile(credentialsMountPath + "accessKey")
+	if err != nil {
+		return err
+	}
 	secretKey, err := os.ReadFile(credentialsMountPath + "secretKey")
+	if err != nil {
+		return err
+	}
 	otcAccountName, err := os.ReadFile(credentialsMountPath + "otcAccountName")
+	if err != nil {
+		return err
+	}
 	projectName, err := os.ReadFile(credentialsMountPath + "projectName")
+	if err != nil {
+		return err
+	}
 	region := strings.Split(string(projectName), "_")[0]
 
 	if err != nil {