-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hashing of accessories to not include the value #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
changed the title
Add some more typing characteristics and services
Cache construction of to_HAP for Characteristic objects
Oct 11, 2023
Codecov Report
@@ Coverage Diff @@
## dev #464 +/- ##
==========================================
+ Coverage 92.48% 92.62% +0.13%
==========================================
Files 20 20
Lines 2223 2263 +40
Branches 274 279 +5
==========================================
+ Hits 2056 2096 +40
Misses 123 123
Partials 44 44
|
Leaving as draft until parent merges |
We have a bug here, we need the hash without the value for the |
bdraco
changed the title
Cache construction of to_HAP for Characteristic objects
Fix hashing of accessories to not include the value
Oct 12, 2023
Fixing conflicts... |
Retesting |
All good |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #463 merged firstThe hash of accessories would include the value which meant that we would increment the
c#
very frequently which could drain battery and force iCloud to sync over and over. The hash should only include the actual config and not the value. The net result is everything could appear unavailable since the iCloud sync would never finish for some users and the constantget_accessories
could overload the system.HA just added support for reloading accessories which will generate a lot more get requests since the
c#
value is going to change more frequently.to_HAP
is now cached to handle this.