Implement and train ColPaliDuo #48
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonywu71
force-pushed
the
implement-and-train-colpali-2
branch
from
77ea6a2
to
af1a1a6
Compare
tonywu71
force-pushed
the
implement-and-train-colpali-2
branch
4 times, most recently
from
cc3b31d
to
8bf550b
Compare
tonywu71
force-pushed
the
implement-and-train-colpali-2
branch
from
3f34cfa
to
ba15d9c
Compare
tonywu71
force-pushed
the
implement-and-train-colpali-2
branch
2 times, most recently
from
bf24d43
to
7fac8f0
Compare
tonywu71
commented
Oct 16, 2024
Comment on lines
+8
to
+11
| class ColbertCELoss(BaseColbertLoss): | ||
| """ | ||
| Cross-entropy loss using the ColBERT scores between the query and document embeddings. | ||
| """ |
There was a problem hiding this comment.
@ManuelFay FYI I have renamed the ColbertLoss into ColbertCELoss to make it less ambiguous. Normally, all the previous occurence of this class have already been renamed, but it's worth one more check just before merging time.
ManuelFay
force-pushed
the
implement-and-train-colpali-2
branch
from
033fb14
to
a173f32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement and train ColPaliDuo. The most noticeable feature of ColPaliDuo is to being able to output both single-vector (dense) and multi-vector (ColBERT-like) embeddings.
Follow-up of #22.