Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Integrazione del download delle videolezioni presenti nel vecchio portale elearning #1

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

barbax7
Copy link

@barbax7 barbax7 commented Sep 17, 2022

No description provided.

@@ -1,3 +1,4 @@
import sre_compile
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this module isn't used anywhere.

Suggested change
import sre_compile

Comment on lines +73 to +74
if data_regex.match(videolesson["href"]).group(1):
cor = data_regex.search(videolesson["href"]).group(2)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data_regex.match(videolesson["href"]) is already used in line 65. What if we would use a variable for it?

params={"inc": inc}
)
)
data.raise_for_status()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Check wether it's safe to raise an error in this part of code, or if it should just return instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants