Fixes #201 - fixeddb:migrate:with_data to compare data schema versions correctly
#202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also fixes #117 |
|
Cherry-picked in #218! Thanks for the contributions |
|
This ended up getting grouped in with changes from #211 in the 8.1.0 release, which was then completely reverted. This change is still needed. |
|
You're right, thanks for the bump. Just released on it's own via #235 |
|
@ilyakatz It doesn't look like that PR contains this fix. It's still pulling the current data version from data-migrate/tasks/databases.rake Line 25 in 88d4737 |
|
hm, @reidab, would you be interested to create a PR? |
reidab
added a commit
to reidab/data-migrate
that referenced
this pull request
Dec 13, 2022
This is a re-creation of ilyakatz#202, which fixes a bug where the AR migration schema version is incorrectly referenced instead of the data migration version. This causes data migrations be to be incorrectly re-run on an otherwise migrated database whenever the most recent schema version is lower than the most recent data version.
ilyakatz
pushed a commit
that referenced
this pull request
Dec 14, 2022
This is a re-creation of #202, which fixes a bug where the AR migration schema version is incorrectly referenced instead of the data migration version. This causes data migrations be to be incorrectly re-run on an otherwise migrated database whenever the most recent schema version is lower than the most recent data version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#201