fix(database_tasks): ConnectionPool deprecation warning in Rails 7.2 #341
Conversation
Fixes this deprecation warning raised in Rails 7.2: ``` DEPRECATION WARNING: ActiveRecord::ConnectionAdapters::ConnectionPool#connection is deprecated and will be removed in Rails 8.0. Use #lease_connection instead. ``` The changed code is simply copied from the Rails repository, please see https://github.com/rails/rails/blob/97169912f197eee6e76fafb091113bddf624aa67/activerecord/lib/active_record/tasks/database_tasks.rb#L520 and https://github.com/rails/rails/blob/97169912f197eee6e76fafb091113bddf624aa67/activerecord/lib/active_record/tasks/database_tasks.rb#L550
lib/data_migrate/database_tasks.rb
Outdated
| def with_temporary_connection(db_config) # :nodoc: | ||
| with_temporary_pool(db_config) do |pool| | ||
| yield pool.connection | ||
| def with_temporary_connection(db_config, clobber: false, &block) # :nodoc: |
There was a problem hiding this comment.
changing the method definition would cause issues for older rails versions (tested against 7.0, 7.1 already supports the clobber keyword)
Would you be able to patch that for rails 7.0?
|
I had a more complete look at the PR above. rails/rails@a918394#diff-4a42b5efdab725af0936f94b4a84dcf6a8be8738e28ed265e0a3e74f275f5048R189 I'm looking at simply changing the behavior here, from |
Also coincidentally fixes the rails 7.2 connection pool deprecation warning
|
Hi @martingregoire I hope you won't mind, I amended your PR a bit, would you be able to give this a go and tell me if it is working for you? |
|
Hi @vprigent, thanks a lot! It works perfectly for us. 👍 |
martingregoire
deleted the
fix/rails-7.2-connection-pool-deprecation-warning
branch
|
Brilliant! I'll cut a new version out today! Thanks for helping out with this resolution |
Fixes this deprecation warning raised in Rails 7.2:
The changed code is simply copied from the Rails repository, please see https://github.com/rails/rails/blob/97169912f197eee6e76fafb091113bddf624aa67/activerecord/lib/active_record/tasks/database_tasks.rb#L520 and
https://github.com/rails/rails/blob/97169912f197eee6e76fafb091113bddf624aa67/activerecord/lib/active_record/tasks/database_tasks.rb#L550.
see #340