Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions and add instructions on publishing to local maven repo #603

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

crowmagnumb
Copy link

I was being held up from updating my website by the old version so I compiled it myself. This bumps some of the dependency versions and explains how to publish locally.

Copy link
Collaborator

@davidwheeler123 davidwheeler123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
I've added one comment about upgrading to Kotlin 2 - is that something that's important to you?
I'll leave @kdubb to approve

const val kotlin = "1.9.10"
const val kotlin = "2.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kotlin 2.0.0 is very new, sometimes it's good to wait a few minor/patch versions before upgrading. But if we do want to upgrade, it looks like we should also update to a more recent Gradle (8.3+) as well

Copy link
Collaborator

@davidwheeler123 davidwheeler123 Jun 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops looks like I was looking at an old branch, we're already using gradle 8.4 🤦

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, unless there's a reason to move to 2.0. Probably stay on 1.9.x.

Upgrading to 1.9.20 seems fine.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No not important at all. I just always try to stay latest on everything while avoiding bleeding edge. I don't even use Kotlin actually, I've been meaning to start switching at least some of my java work to it but haven't gone there yet. So 1.9 is fine with me. :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to 1.9.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants