Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: use give_maybe_safe_unserialize for user data #7533

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Enhancement: use give_maybe_safe_unserialize for user data #7533

merged 2 commits into from
Sep 6, 2024

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Sep 4, 2024 •
edited by jonwaldstein
Loading

Resolves GIVE-1176

Description

This PR implements a defensive approach to always check if is necessary to unserialize user data after removing backslashes.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Sep 4, 2024
@glaubersilva glaubersilva marked this pull request as ready for review September 4, 2024 21:16
jonwaldstein
jonwaldstein approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦾

rickalday
rickalday approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA test.

@jonwaldstein jonwaldstein changed the base branch from develop to master September 6, 2024 12:56
@jonwaldstein jonwaldstein changed the base branch from master to develop September 6, 2024 12:56
@glaubersilva glaubersilva force-pushed the enhancement/unserialize-user-info-GIVE-1176 branch from e861dcf to cfd74e4 Compare September 6, 2024 13:10
@glaubersilva glaubersilva changed the base branch from develop to master September 6, 2024 13:11
@jonwaldstein jonwaldstein merged commit 4f6d503 into master Sep 6, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the enhancement/unserialize-user-info-GIVE-1176 branch September 6, 2024 19:35
@glaubersilva glaubersilva restored the enhancement/unserialize-user-info-GIVE-1176 branch September 9, 2024 18:44
@glaubersilva glaubersilva deleted the enhancement/unserialize-user-info-GIVE-1176 branch September 9, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bordoni bordoni bordoni approved these changes

@rickalday rickalday rickalday approved these changes

@jonwaldstein jonwaldstein jonwaldstein approved these changes

Assignees

@glaubersilva glaubersilva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glaubersilva @bordoni @rickalday @jonwaldstein