New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: update html field template to use interweave #7539

Open

jonwaldstein wants to merge 2 commits into develop from refactor/html-field-interweave

Contributor

jonwaldstein commented Sep 13, 2024 •

edited

Loading

Description

This updates our html field template to use interweave instead of dangerouslySetInnerHTML

Affects

html fields

Visuals

N/A

Testing Instructions

Make sure the html field works as epected

Pre-review Checklist

Acceptance criteria satisfied and marked in related issue
Relevant @unreleased tags included in DocBlocks
Includes unit tests
Reviewed by the designer (if follows a design)
Self Review of code and UX completed

Jon Waldstein added 2 commits

September 13, 2024 11:25


          refactor: replace html field with interweave

9cbe7e4


          docs: add since tag

a1e038f

Contributor Author

jonwaldstein commented Sep 18, 2024

I realized this might not what people want for our html field as it strips out html like script tags 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet