Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused dynamic property assignment of $auto_updater_obj from Give_License constructor #7586

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Oct 24, 2024

Resolves GIVE-1372

Description

This resolves the follow PHP deprecation notice:

PHP Deprecated:  Creation of dynamic property Give_License::$auto_updater_obj is deprecated in /Users/jonwaldstein/Herd/givewp/wp-content/plugins/give/includes/class-give-license-handler.php on line 233

This property appears to be leftover from the early days of Give when there was an auto updater. I could not find this method or any use of the property anymore, furthermore it was being assigned to null in construct.

Affects

This technically touches the Give License class however, nothing should be affected as this is dead code.

Screenshot 2024-10-24 at 5 13 38 PM

Visuals

N/A

Testing Instructions

  • Make sure there is no more php warning
  • Make sure our license system works as expected.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! I couldn’t find any usage of that in any of the repositories.

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests

@jonwaldstein jonwaldstein merged commit 314b57d into develop Oct 28, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/php-warning-give-license branch October 28, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants