Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 10xx FlexIO CCM configuration #140

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Conversation

Florob
Copy link
Contributor

@Florob Florob commented Sep 10, 2023

This adds support for setting source clock and dividers for FlexIO clock roots in accordance with the RMs

This is WIP because I haven't gotten around to testing the current version on actual hardware yet, but I'd like feedback on the general approach.
The issue here is that FLEXIO1_CLK_ROOT on 1010/1020 is FLEXIO2_CLK_ROOT on 106x, so there is some magic involved in getting the module names and doc comments right. Due to this it might also make sense to move this into a separate module and re-export it.

@Florob Florob marked this pull request as draft September 10, 2023 14:43
@mciantyre
Copy link
Member

I like it. The macros are convenient, and we could lower their invocation into the chip configuration modules, co-locating them with the other chip-specific CCM modules. I pushed a commit to show this, but we can throw it away.

@Florob Florob marked this pull request as ready for review November 21, 2023 21:45
@Florob Florob changed the title WIP: Add 10xx FlexIO CCM configuration Add 10xx FlexIO CCM configuration Nov 21, 2023
@Florob
Copy link
Contributor Author

Florob commented Nov 21, 2023

I've finally gotten around to verifying this. After cursing at the PFD frequencies being wildly different from what is in the datasheet for a while I'm now reasonably confident that this is correct.

@mciantyre I agree with your changes and squashed them into the initial commit, as I don't think having them separate makes much sense.

Copy link
Member

@mciantyre mciantyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. I rebased onto main, and I'll release in 0.5.4.

@mciantyre mciantyre merged commit 26b1b79 into imxrt-rs:main Nov 26, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants