Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix publishbackgroundall dependency index #121

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Commits on Oct 23, 2024

  1. [BUGFIX] Fix publishbackgroundall dependency index

    The command in2publish:workflow:publishbackground from the premium
    plugin may skip pages depending on previous pages:
    
     1. Assume a page and a child page are scheduled for publishing.
     2. Assume the child page gets processed first.
     3. The child page will fetch the parent page as a dependency. The
        parent page will get recorded in the index.
     4. When the parent page record gets fetched from the database, it will
        already be in the index. It will not get added to any record index
        recording.
     5. The RecordTreeBuilder assumes that pages scheduled for publishing
        get added to the record index recording buildRecordTree, which did
        not happen in step 4.
     6. The parent page gets marked as published, but changes will not
        actually have been published.
    
    This commit ensures the parent page gets added to the buildRecordTree
    record index recording. It archives that by adding pages to the record
    index recording even if it was already in the index.
    
    As this code is pretty deep, I am not quite sure about unintended side
    effects. Intense testing is advisable.
    dreistromlandMf committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    286bfa4 View commit details
    Browse the repository at this point in the history