-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-parametric statistics #233
base: master
Are you sure you want to change the base?
Conversation
34fbedc
to
6f095b8
Compare
Thanks @cmaumet. So have we defined a new type of statistic, the 'pseudo t'? (Which really should instead be called the 'Smoothed Variance t-test' |
Thanks @nicholst, the new statistic term is now updated to |
666b2e4
to
fd701f9
Compare
(Just rebased) |
e0516a6
to
2c4ea98
Compare
Created new terms for:
|
These |
We discussed this issue on NIDASH call on December 15th.
|
@cmaumet : Yes! We should model uncorrected and corrected p-value as well. |
This pull request has been rebased on master and the following updates included:
|
looking at it now, looks great - |
Good question @jbpoline. Your definition amounts to the strict parametric definition. In that vein the smoothed variance t-test is Gaussian divided by independent approximate chi-squared. Colloquially, I think of any "estimate divided by standard error" as a "t ratio", and certainly in a nonparametic setting we don't need the parametric assertions. I find "smoothed variance t-test" a very clear description, more informative than Andrew Holmes' preferred "pseudo t-test". But I'm up for suggestions they are more precise. What do you suggest?
|
@cmaumet : What's the status of this PR... Are we waiting for resolution of the discussion from 2015? Or for another version / release candidate of NIDM-Results to be created? |
Hi @nicholst! I think we only need to check that what is in here is consistent with our first prototype for SnPM (SnPM-toolbox/SnPM-devel#45). If @TomMaullin is up for it, we could also do the same for randomise, just to check that the proposed model fits our needs. |
Sorry for being slow but I'm trying to keep track of all of our NIDM-Results exporter work:
So the question is, for SnPM: What should we do? Use this PR? Or switch to JSON API? @cmaumet - Please feel free to edit this comment to correct details in-line. |
Hi @nicholst! Sorry for the confusion!
The JSON API is a intermediate (flattened) representation used by the exporters to more easily generate a NIDM-Results export. But, we still need to have the information represented in NIDM in the first place. For non-parametric statistics:
My suggestion was that before we merge this PR, we do a full cycle 1 -> 2 -> 3 as a sanity check that our model fits our needs. How does this sound? |
OK... so... how to action this... Are you poised to do this all? Or you taking the lead on 2, Tom MS w/ my help, 3? |
Suggested action items/people:
Is that okay? @nicholst, @TomMaullin |
@cmaumet : This is good for me: @TomMaullin are you clear what needs to be done? My only question is: Does the NIDM FSL exporter currently use the JSON API? I.e. will @TomMaullin & my PR to the exporter use the JSON API? |
That's a good point! The integration of the JSON API in the NIDM FSL exporter is still work-in-progress, and this is another todo point [now added above]. Maybe you can start by finishing the collection of all the required information in the randomise output folder while I focus on JSON API integration and we can reconvene afterwards? |
OK, this sounds like a plan.
|
This is a work-in-progress, developed with @nicholst, to model non-parametric inference.
The proposed modifications are as follows:
nidm:isParametric
innidm:Inference
to specify whether parametric or non-parametric inference is performed.nidm:NonParametricNullDistribution
(used bynidm:Inference
and only available ifisParametric
=true
) with attributes:nidm:numberOfPermutations
,nidm:exchangeabilityBlockSize
(optional).nidm:varianceSmoothingFWHM
innidm:StatisticMap
to specify the degree of variance smoothing forPseudo-TStatistic
.nidm:NonParametricSymmetricDistribution
replaced bynidm:SymmetricDistribution
innidm:ErrorModel
(as discussed at Non-parametric distributions ISA-tools/stato#29 and Non-parametric symmetric distribution ISA-tools/stato#31).