[2.x] Change TypeScript module resolution in the Svelte adapter #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes TypeScript module resolution issues within our monorepo setup that were preventing the detection of type errors during the launch of v1.3.0-beta.1. This happened because the
packages/svelte/test-appand Svelteplaygroundsprojects weren't detecting type definitions from the Svelte adapter. The existing module resolution settings, copied from a fresh SvelteKit installation, were incompatible with our NPM workspace structure.Changing the TypeScript module resolution to the same values as the other adapters fixes this issue in the Svelte adapter.