Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ implement bottom navigation tabs layout #38

Open
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

gaa0
Copy link
Member

@gaa0 gaa0 commented Oct 27, 2024

설명 (Description)

  • 화면 아래의 탭 구현

체크리스트 (Checklist)

  • iOS에서 테스트 완료
  • Android에서 테스트 완료
  • 웹에서 테스트 완료

@gaa0 gaa0 requested a review from a team as a code owner October 27, 2024 23:53
@gracefullight gracefullight added the feat New feature or request label Oct 28, 2024
@gracefullight
Copy link
Member

gracefullight commented Oct 28, 2024

P1
web-publish.ts 파일 다른 앱에서 복사하셔서 넣어주셔요~

커맨드는 제 건에서 넣어서 파일만 추가해주셔도 될것 같습니다!
https://github.com/infinite-loop-factory/app-factory/pull/37/files#diff-ab9badec8b0702663c04eda540c1e48fda9c846f884ca36d0501584a79739429R16

Comment on lines +11 to +26
const styles = StyleSheet.create({
container: {
flex: 1,
justifyContent: "center",
alignItems: "center",
backgroundColor: "#0D0D0D",
},
text: {
color: "white",
},
button: {
fontSize: 20,
textDecorationLine: "underline",
color: "#fff",
},
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1
이부분 nativewind className으로 바꿔주셔요~ (전 GPT로 했는데 잘 바꿔주더라구요.)

Comment on lines +11 to +21
const styles = StyleSheet.create({
container: {
flex: 1,
backgroundColor: "#0D0D0D",
justifyContent: "center",
alignItems: "center",
},
text: {
color: "#fff",
},
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1
이부분 nativewind className으로 바꿔주셔요~

Comment on lines +17 to +30
const styles = StyleSheet.create({
container: {
flex: 1,
backgroundColor: "#0D0D0D",
justifyContent: "center",
alignItems: "center",
},

button: {
fontSize: 20,
textDecorationLine: "underline",
color: "#fff",
},
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1
이부분 nativewind className으로 바꿔주셔요~

apps/playlist/app/_layout.tsx Outdated Show resolved Hide resolved
pnpm-lock.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Nov 2, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@ckrbqja
Copy link
Member

ckrbqja commented Nov 2, 2024

저는 CLA 문서를 읽었으며, CLA에 서명합니다.

github-actions bot added a commit that referenced this pull request Nov 2, 2024
@github-actions github-actions bot added size/m and removed size/xl labels Nov 7, 2024
@gracefullight
Copy link
Member

안 되시던 커밋 올려주세요~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants