-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/reaction speed test measure #52
Open
JAM-PARK
wants to merge
14
commits into
main
Choose a base branch
from
feature/reaction-speed-test-measure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAM-PARK
requested review from
gracefullight,
gaa0,
ckrbqja and
Lim-Ji-Hyeon
November 16, 2024 06:57
…patch 추가" This reverts commit 0fe1850.
- react-native-css-interop update 이후 jest failed - mocking 추가: test 에러 발생하는 useColorScheme
- react-native-svg: 14.1.0 - react-native-css-interop: ^0.0.36
- reaction-speed-test만 [email protected] 버전 사용 중
JAM-PARK
force-pushed
the
feature/reaction-speed-test-measure
branch
from
November 17, 2024 03:51
4419cf2
to
8eec855
Compare
@@ -0,0 +1,7 @@ | |||
jest.mock("nativewind", () => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 jest.setup.ts로 가져가도 동작하려나요??!
Lim-Ji-Hyeon
approved these changes
Nov 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
우와!! 수고하셨습니다 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
설명 (Description)
react-native-svg
를 사용하다 라이브러리 버전 문제가 생겨 올리는 PR입니다.관련 이슈 (Related Issues)
체크리스트 (Checklist)
리뷰 가이드라인 (Review Guidelines)
P1 (Priority 1): 반드시 바로 수정해야 할 항목입니다. 기능에 큰 영향을 주거나, 배포 전에 꼭 해결해야 하는 중요한 사항입니다.
P2 (Priority 2): 수정하면 코드가 더 개선될 수 있는 사항입니다. 큰 이슈는 아니지만, 수정하면 코드가 더 깔끔하고 유지보수가 쉬워집니다.
P3 (Priority 3): 당장 수정하지 않아도 괜찮지만, 나중에 개선하면 도움이 되는 사항입니다. 기본적으로 모든 리뷰는 P3로 간주해주시면 됩니다.