Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Redux-Toolkit Docs for Integration #1323

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update Redux-Toolkit Docs for Integration #1323

wants to merge 4 commits into from

Conversation

shoaib2527
Copy link

Update documentation to clarify integration with redux-toolkit: enhancers should now be passed to enhancers in configureStore instead of middlewares in createStore for improved compatibility.

@shoaib2527
Update plugin-redux.md
0d2c8a5 
Adds docs to integrate with redux-toolkit.
@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Nov 22, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

jamonholmgren
jamonholmgren reviewed Nov 28, 2023
View reviewed changes
docs/plugin-redux.md Outdated Show resolved Hide resolved
jamonholmgren
jamonholmgren approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@jamonholmgren jamonholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (with the small change that I committed)

markrickert added a commit that referenced this pull request Dec 13, 2023
@markrickert
chore(docs): Update redux to add section about RTK
777d32a 
Closes #1323

Thank you for your contribution, @shoaib2527!
@markrickert markrickert mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamonholmgren jamonholmgren jamonholmgren approved these changes

@ryanlntn ryanlntn ryanlntn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoaib2527 @jamonholmgren @ryanlntn