[Merged by Bors] - feat: enable socket keepalive by default #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 28, 2023
Added an ability to set socket `keepalive` property. By default, all fluvio TCP connections will have set `keepalive=true`. This is needed to prevent silently closing TCP connections by OS or network gateways when there is no traffic for an extended period of time. It often happens for consumers when there is no data on the topic for a period of more than one day. TCP session gets closed but the consumer does not determine that and keeps waiting for the data. For instance https://github.com/infinyon/roadmap/issues/85
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an ability to set socket
keepaliveproperty.By default, all fluvio TCP connections will have set
keepalive=true. This is needed to prevent silently closing TCP connections by OS or network gateways when there is no traffic for an extended period of time. It often happens for consumers when there is no data on the topic for a period of more than one day. TCP session gets closed but the consumer does not determine that and keeps waiting for the data. For instance https://github.com/infinyon/roadmap/issues/85