Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feature(http-client): add async-std compat layer and hyper connector #215

Closed

Conversation

matheus-consoli
Copy link
Contributor

Part 1 of the mini-http-client implementation.

This PR updates some dependencies and adds the async-std and hyper compatibility building blocks.

Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

Couple of issues:

  • return anyhow error
  • need to bump up crate version
  • integration test. there are few network tests as example

src/http_client/async_std_compat.rs Outdated Show resolved Hide resolved
@matheus-consoli
Copy link
Contributor Author

@sehz, I updated the crate version and we're now using anyhow for error handling

there are integration tests in the second part of this feature (#216)

@sehz
Copy link
Contributor

sehz commented Oct 17, 2023

Since this is feature, it seems only need patch version change?

@digikata
Copy link
Contributor

It looks like that change is already there 0.6 -> 0.7?

Cargo.toml Outdated Show resolved Hide resolved
@matheus-consoli
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 17, 2023
…215)

Part 1 of the `mini-http-client` implementation.

This PR updates some dependencies and adds the `async-std` and `hyper` compatibility building blocks.
@bors
Copy link

bors bot commented Oct 17, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feature(http-client): add async-std compat layer and hyper connector [Merged by Bors] - feature(http-client): add async-std compat layer and hyper connector Oct 17, 2023
@bors bors bot closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants