-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feature(http-client): add async-std compat layer and hyper connector #215
[Merged by Bors] - feature(http-client): add async-std compat layer and hyper connector #215
Conversation
03d2fcc
to
92e9e91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
Couple of issues:
- return anyhow error
- need to bump up crate version
- integration test. there are few network tests as example
Since this is feature, it seems only need patch version change? |
It looks like that change is already there 0.6 -> 0.7? |
c1c65aa
to
e18f6a0
Compare
bors r+ |
…215) Part 1 of the `mini-http-client` implementation. This PR updates some dependencies and adds the `async-std` and `hyper` compatibility building blocks.
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Part 1 of the
mini-http-client
implementation.This PR updates some dependencies and adds the
async-std
andhyper
compatibility building blocks.