added optional gradient. added halo on active. added aria labels to a… #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregLongo
requested review from
juliajames12,
mavarius and
a team
as code owners
TCL735
suggested changes
Jan 9, 2022
Comment on lines
+31
to
+33
| // &:focus { | ||
| // outline: none; | ||
| // } |
There was a problem hiding this comment.
Unused code should be removed not commented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ll inputs
Closes #
---Note: This is an interview assignment for UX Engineer Position --
Changes
Modified Range Slider component :
Screenshots
// Add screenshots here if relevant
Checklist
Check all that apply