allow additional properties #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add to the description how this would prevent the breakage? |
updated the description |
venkat-iblox
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the client from breaking whenever a new field is introduced in the APIs.
The models used to break because the unmarshall code uses
decoder.DisallowUnknownFields(). This PR fixes that and also gives the oppurtunity for the user to pass new properties that are not supported by this client, but available in the API. They can pass these properties using the "AdditionalProperties" maphttps://github.com/infobloxopen/bloxone-go-client/pull/35/files#diff-56f2d57c2ab9a57559a741675a96a11854426603c730b32730b2701085b63a91L503