Workflow for DFP Service #126
Conversation
…loxone into workflow
…loxone into workflow
| } | ||
|
|
||
| provider "bloxone" { | ||
| csp_url = "https://csp.infoblox.com" |
There was a problem hiding this comment.
We suggest to use environment variables, if then I would recommend to update the Terraform content with ENV variables for both CSP & API. Then add some comment for ENV variable with value.
There was a problem hiding this comment.
Users generally provide credentials as Env variables . This is given just as an example here . We have also added a warning against hard coded credentials below !
docs/guides/quickstart-dfp.md
Outdated
| You can also use the following environment variables to configure the provider: | ||
| `AWS_REGION`, `AWS_ACCESS_KEY_ID`, and `AWS_SECRET_ACCESS_KEY`. | ||
|
|
||
| To create an EC2 instance with DHCP service, you will need to have the following information: |
There was a problem hiding this comment.
Why do we mention about DHCP service here ?
There was a problem hiding this comment.
Also, why are we creating the host with DHCP service in DFP example ?
There was a problem hiding this comment.
This is a typo . Has been modified.
docs/guides/quickstart-dfp.md
Outdated
| } | ||
|
|
||
| # Create the DFP Service | ||
| resource "bloxone_dfp_service" "example" { |
There was a problem hiding this comment.
Match the name 'bloxone_dfp_service' in all cases through out the document. In previous step, Infra service was created with name 'example_dfp_service' and here, we mentioned resource with different name.
docs/guides/quickstart-dfp.md
Outdated
| terraform plan | ||
| ``` | ||
|
|
||
| Finally, you will create the Security Policy that uses the Custom List, Bypass Code and an External Network created earlier. |
There was a problem hiding this comment.
If this document is specific to DFP, then I would not like to add content for Bypass Code and External Network List
There was a problem hiding this comment.
The idea was that , since we are already demonstrating a DFP based Security policy , we demonstrate all the other TD objects associated with it . This has been mentioned in the description too .
docs/guides/quickstart-dfp.md
Outdated
| terraform plan | ||
| ``` | ||
|
|
||
| Finally, you will create the Security Policy that uses the Custom List, Bypass Code and an External Network created earlier. |
There was a problem hiding this comment.
Here, it is good to mention that create policy with DFP.
…loxone into workflow
…loxone into workflow
No description provided.