Fixes the use of eval_metric in case of EarlyStoppingShapRFECV with LightGBM #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulZhutovsky
changed the title
|
Hi @PaulZhutovsky, thanks for the fix! This microsoft/LightGBM#6035 provides an opportunity for us to fix the automated checks. I'll review the code. |
added 4 commits
July 4, 2024 16:21
|
@PaulZhutovsky |
|
@PaulZhutovsky thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #259 in the exact way described in the issue.
It indeed removes the warning and uses the defined
eval_metricin case of LightGBM. I have no idea how to "formally" test that. @ReinierKoops please advice.