Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make executor report get facts to scheduler #8268

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jptrindade
Copy link
Contributor

Description

  • Short description here *

closes #8190

Self Check:

Strike through any lines that are not applicable (~~line~~) then check the box

  • Attached issue to pull request
  • Changelog entry
  • Type annotations are present
  • Code is clear and sufficiently documented
  • No (preventable) type errors (check using make mypy or make mypy-diff)
  • Sufficient test cases (reproduces the bug/tests the requested feature)
  • Correct, in line with design
  • End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
  • If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

@jptrindade jptrindade self-assigned this Oct 25, 2024
…-facts-to-scheduler

# Conflicts:
#	src/inmanta/agent/in_process_executor.py
#	src/inmanta/deploy/persistence.py
#	src/inmanta/deploy/scheduler.py
#	tests/deploy/test_scheduler_agent.py
…-facts-to-scheduler

# Conflicts:
#	src/inmanta/deploy/scheduler.py
@@ -21,10 +21,10 @@
import uuid
from copy import deepcopy

import inmanta.types
import inmanta.types # noqa: F401
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly sure if this is needed or we can remove it

Comment on lines -38 to -39
import inmanta.types
import inmanta.util
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be wrong to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make executor report facts to the scheduler
1 participant