Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/5766 improve filtering get instance form #5777

Closed

Conversation

LukasStordeur
Copy link
Collaborator

@LukasStordeur LukasStordeur commented May 30, 2024

Description

closes #5766

The dropdown displayed the UUID previously when editing an instance. It does show the correct name now, and the filtering works whether the user types in a UUID or an instance name.

Recording.2024-05-30.141349.mp4

@LukasStordeur LukasStordeur self-assigned this May 30, 2024
@LukasStordeur LukasStordeur added the merge-tool-ready This ticket is ready to be merged in label May 30, 2024
@inmantaci
Copy link
Contributor

Processing this pull request

@inmantaci inmantaci removed the merge-tool-ready This ticket is ready to be merged in label May 30, 2024
@inmantaci
Copy link
Contributor

Pull request rejected by merge tool. No change entry file found

@LukasStordeur LukasStordeur added the merge-tool-ready This ticket is ready to be merged in label May 30, 2024
@inmantaci
Copy link
Contributor

Processing this pull request

@inmantaci inmantaci removed the merge-tool-ready This ticket is ready to be merged in label May 30, 2024
@inmantaci
Copy link
Contributor

Pull request rejected by merge tool. No change entry file found

@LukasStordeur LukasStordeur added the merge-tool-ready This ticket is ready to be merged in label May 30, 2024
@inmantaci
Copy link
Contributor

Processing this pull request

inmantaci pushed a commit that referenced this pull request May 30, 2024
#5766, PR #5777)

# Description

closes #5766

The dropdown displayed the UUID previously when editing an instance. It does show the correct name now, and the filtering works whether the user types in a UUID or an instance name.

https://github.com/inmanta/web-console/assets/44098050/05fe55d8-1bb3-4fd1-acd5-acc1d0e7d51f
@inmantaci
Copy link
Contributor

Merged into branches iso7, master in 6c60de6

@inmantaci inmantaci closed this May 30, 2024
@inmantaci inmantaci deleted the issue/5766-improve-filtering-get-instance-form branch May 30, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-tool-ready This ticket is ready to be merged in
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace filter.name with new filtering on GET instances
3 participants