-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/5766 improve filtering get instance form #5777
Closed
LukasStordeur
wants to merge
7
commits into
master
from
issue/5766-improve-filtering-get-instance-form
Closed
Issue/5766 improve filtering get instance form #5777
LukasStordeur
wants to merge
7
commits into
master
from
issue/5766-improve-filtering-get-instance-form
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matborowczyk
approved these changes
May 30, 2024
matborowczyk
approved these changes
May 30, 2024
Processing this pull request |
Pull request rejected by merge tool. No change entry file found |
Processing this pull request |
Pull request rejected by merge tool. No change entry file found |
Processing this pull request |
inmantaci
pushed a commit
that referenced
this pull request
May 30, 2024
#5766, PR #5777) # Description closes #5766 The dropdown displayed the UUID previously when editing an instance. It does show the correct name now, and the filtering works whether the user types in a UUID or an instance name. https://github.com/inmanta/web-console/assets/44098050/05fe55d8-1bb3-4fd1-acd5-acc1d0e7d51f
Merged into branches iso7, master in 6c60de6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #5766
The dropdown displayed the UUID previously when editing an instance. It does show the correct name now, and the filtering works whether the user types in a UUID or an instance name.
Recording.2024-05-30.141349.mp4