Issue/composer v2 #5985
Closed
Issue/composer v2 #5985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…73-persisting-coordinates
Co-authored-by: Lukas <[email protected]>
Co-authored-by: Lukas <[email protected]>
Co-authored-by: Lukas <[email protected]>
…73-persisting-coordinates
…a/web-console into issue/5273-persisting-coordinates
…73-persisting-coordinates
…73-persisting-coordinates
Co-authored-by: Lukas <[email protected]>
Co-authored-by: Lukas <[email protected]>
Co-authored-by: Lukas <[email protected]>
Co-authored-by: Lukas <[email protected]>
Co-authored-by: Lukas <[email protected]>
Co-authored-by: Lukas <[email protected]>
Co-authored-by: Lukas <[email protected]>
Co-authored-by: Lukas <[email protected]>
…to issue/composer-v2
LukasStordeur
approved these changes
Oct 25, 2024
| instanceAsTable: ServiceEntityBlock, | ||
| presentedAttrs?: "candidate" | "active", | ||
| ) { | ||
| presentedAttrs: "candidate" | "active", |
There was a problem hiding this comment.
Make ticket: there's a type for these already; it would be better to use the type using the Pick type.
| }; | ||
| } | ||
|
|
||
| interface ComposerEntityOptions { |
|
Processing this pull request |
|
Pull request rejected by merge tool. The tests for this branch did not succeed. |
|
Processing this pull request |
|
Merged into branches master in 7a154ab |
inmantaci
pushed a commit
that referenced
this pull request
Oct 28, 2024
…ts general functionalities with regular form, and improve the user experience. This change includes: A right sidebar, to have better access to the form fields of different parts of the instance A left sidebar, from which we can drag and drop embedded entities and existing Inter-Service Relations from the inventory. Inter-Service Relations can only be edited when opened individualy in the Instance Composer. Zooming can now be done with a slider, and two new functionalities have been added. Zoom-to-fit and full-screen mode. (Issue #5868, PR #5985) # Description Pull request that merge all changes made to the instance composer to move away from old design and functionalities and make composer to follow form-like behaviour Task that are still required for full redesign: #5870 #5986 #5987 #5988 #5989 #5990 #5991 https://github.com/user-attachments/assets/12001341-4bb4-43dc-af3b-88c78993ebe4 closes #5868 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [ ] Changelog entry - [ ] Code is clear and sufficiently documented - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pull request that merge all changes made to the instance composer to move away from old design and functionalities and make composer to follow form-like behaviour
Task that are still required for full redesign:
#5870 #5986 #5987 #5988 #5989 #5990 #5991
Screen.Recording.2024-10-16.at.12.39.47.mov
closes #5868
Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the box