-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove iogx #122
remove iogx #122
Conversation
3c640cc
to
1fae27c
Compare
706c444
to
4e4c2eb
Compare
}; | ||
}; | ||
|
||
upToDatePlutusScriptCheck = pkgs.runCommand "up-to-date-plutus-scripts-check" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be nice to have this in a seperate script, perhaps somewhere in nix/scripts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. This is just a migration from how it was before (and legacy stuff from mlabs). And there's probably a non-nix way within the makefiles somewhere as well, so I'll just create a ticket to keep track of it.
In general, let scripts be useable outside of nix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I saw it wasn't any better before the change, just nice to split up longer than a few lines to its own file
4e4c2eb
to
0dbc39a
Compare
Nix shell doesn't seem to provide cabal. Not sure if I'm missing something.
|
Thanks, looks like iogx provided that while it made its shells. I'll add the toolchains missing from there |
c71aee0
to
d7dc6de
Compare
After pulling:
Minor comment: |
Thanks Krisztian. yeah, the tooling isn't correct yet. there was a whole chain of tooling that iogx would provide locally. I'm still working on it and will re-request your review once I get it right. |
5a8658c
to
603de64
Compare
@kpinter-iohk can you to see if all of your shell/build tooling is functional now? |
603de64
to
39ae605
Compare
f2f872f
to
2bf4f79
Compare
d75d2c7
to
09b595c
Compare
ETCM-8233 iogx is unnecessarily complex for our use cases. nosys essentially only handles systems for you, rewriting the outputs. As such, it also fixes interfaces lik e 'nix flake show' where Input From Derivation (haskell.nix) would usually break the interface. Other changes: - Shells made into a single shell - Updated nixci to omnix - Cleanup outputs
09b595c
to
6d4d7a0
Compare
I see that the CI broke because script sizes changed. I wanted to look into this locally, however
|
21dfc1c
to
0eeb2c2
Compare
0eeb2c2
to
c048272
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🥇
ETCM-8233
iogx is unnecessarily complex for our use cases. nosys essentially only handles systems for you, rewriting the outputs. As such, it also fixes interfaces like 'nix flake show' where Input From Derivation (haskell.nix) would usually break the interface.
Other changes:
Prereview checklist
# Unreleased
header using the appropriate sub-headings with links to the appropriate issues/PRs.