Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HDF-EOS5 metadata for HyP3 products #1180

Merged
merged 6 commits into from
Apr 25, 2024
Merged

Add HDF-EOS5 metadata for HyP3 products #1180

merged 6 commits into from
Apr 25, 2024

Conversation

forrestfwilliams
Copy link
Collaborator

@forrestfwilliams forrestfwilliams commented Apr 16, 2024 •
edited
Loading

Description of proposed changes
At @yunjunz's suggestion, this PR adds the startUTC, stopUTC, and relativeOrbit fields to HyP3-derived products to support HDF-EOS5 conversion.

Reminders

  • Fix hyp3: more metadata for HDF-EOS5 support #1162
  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@forrestfwilliams
Copy link
Collaborator Author

@yunjunz not sure I got startUTC and stopUTC right here. Should these be attributes of each interferogram, or are they the start/stop time for the entire stack (i.e., min input SLC date, and max input SLC date)?

@yunjunz yunjunz self-requested a review April 16, 2024 16:14
yunjunz
yunjunz requested changes Apr 16, 2024
View reviewed changes
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @forrestfwilliams, start/stopUTC should come from the same acquisition, so the current calculation should be fine.

However, we would also need the ascending note time of the same acquisition to calculate the ASF frame number for S1. I guess that could be added later in the HyP3 metadata? Regardless, we could merge this PR without this extra attribute.

src/mintpy/prep_hyp3.py Outdated Show resolved Hide resolved
src/mintpy/prep_hyp3.py Outdated Show resolved Hide resolved
@forrestfwilliams forrestfwilliams mentioned this pull request Apr 18, 2024
Merged
7 tasks
@yunjunz
Copy link
Member

yunjunz commented Apr 19, 2024 •
edited
Loading

Hi @forrestfwilliams, start/stopUTC should come from the same acquisition, so the current calculation should be fine.

My misunderstanding: the start/stopUTC should come from the same acquisition, i.e. the starting and ending time of one image, so the current calculation is NOT correct. We could grab the two time stamps from the Reference or Secondary file name directly.

@yunjunz yunjunz changed the title Add hdf-eos5 metadata for HyP3 products Add HDF-EOS5 metadata for HyP3 products Apr 23, 2024
yunjunz
yunjunz approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@yunjunz yunjunz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me now. Thank you @forrestfwilliams.

Update: beam_swath is needed for hyp3-gamma/isce2 products. I will push another commit here.

@forrestfwilliams
Copy link
Collaborator Author

Sounds good! Do we need to update startUTC/stopUTC, or are they correct now?

@yunjunz
Copy link
Member

yunjunz commented Apr 24, 2024

Sounds good! Do we need to update startUTC/stopUTC, or are they correct now?

They are fixed now.

@yunjunz yunjunz merged commit 4e3ad9f into main Apr 25, 2024
7 of 8 checks passed
@yunjunz yunjunz deleted the hyp3_eos5 branch April 25, 2024 10:23
@yunjunz yunjunz mentioned this pull request Apr 25, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunjunz yunjunz yunjunz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hyp3: more metadata for HDF-EOS5 support
2 participants
@forrestfwilliams @yunjunz