Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update HyP3 example dataset RidgecrestSenDT71 #1182

Merged
merged 4 commits into from
Apr 23, 2024
Merged

update HyP3 example dataset RidgecrestSenDT71 #1182

merged 4 commits into from
Apr 23, 2024

Conversation

forrestfwilliams
Copy link
Collaborator

@forrestfwilliams forrestfwilliams commented Apr 18, 2024

Description of proposed changes

Update the HyP3 full SLC sample data to include new metadata field necessary to support PR #1180. New example data tarball can be downloaded here.

Also makes small updates to the HyP3 section of the dir_structure.md document.

Reminders

  • Fix for PR Add HDF-EOS5 metadata for HyP3 products #1180
  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@forrestfwilliams
Copy link
Collaborator Author

@yunjunz I could use your help uploading the new sample data to the correct place on Zenodo.

@yunjunz
Copy link
Member

yunjunz commented Apr 18, 2024

@yunjunz I could use your help uploading the new sample data to the correct place on Zenodo.

Hi @forrestfwilliams, I added you to the creator and contributor list on the previous Zenodo page. Could you try to see if you could update a new version?

If not, I am happy to test and upload the version. Let me know please.

@forrestfwilliams
Copy link
Collaborator Author

forrestfwilliams commented Apr 18, 2024

Looks like I have a couple of Zenodo profiles. Could you make sure the username ForrestWilliams is a contributor?

@yunjunz
Copy link
Member

yunjunz commented Apr 19, 2024

I added you connected with this ORCID number, which I believe is correct.

After more reading, it seems that sharing the writing permission of a single repo with another user is not possible on Zenodo yet (zenodo/zenodo#151). So I will go ahead and upload it tonight.

@yunjunz yunjunz self-requested a review April 19, 2024 03:04
@yunjunz
Copy link
Member

yunjunz commented Apr 19, 2024

The new dataset runs through #1180 without issue. However, this dataset missed the lower half of the data, as shown below. Maybe you want to recreate a new one that covers the entire EQ? BTW, the previous example dataset uses desc track 71, while this one uses asc track 64, which is totally fine if there is no data gap issue.

unwrapPhase_wrap

+ use * for more generic filename support

+ change the reference lat/lon
@forrestfwilliams
Copy link
Collaborator Author

@yunjunz shoot you're right, sorry! I'll get you a new version based on desc track 71.

@forrestfwilliams
Copy link
Collaborator Author

forrestfwilliams commented Apr 23, 2024

@yunjunz here is a link to a descending 71 track version of the data.

The main smallbaselineApp run works great, but I noticed that there is an issue running smallbaselineApp.py --plot at the end of processing that I haven't seen before. Running the sub-command:

view.py --dpi 150 --noverbose --nodisplay --update --memory 4.0 numInvIfgram.h5 --mask no

Results in an error within the matplotlib axis tick functionality:

  File "lib/python3.11/site-packages/matplotlib/ticker.py", line 799, in _set_format
    loc_range_oom = int(math.floor(math.log10(loc_range)))
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: cannot convert float NaN to integer

Have you come across this one before?

For now, I've disabled plotting in the configuration document, so we don't encounter the error when running the standard smallbaselineApp.py, but we may want to circle back to this at some point.

@yunjunz
Copy link
Member

yunjunz commented Apr 23, 2024

Thank you @forrestfwilliams for the update. I have uploaded the dataset to Zenodo (https://zenodo.org/records/11049257), an ERA5.h5 file is also attached within the tar ball, to simplify the test / running for the first-time user.

I am able to re-produce the error you have. If I turn off the NO_DATA_VALUE handling, the plot went back to normal. But I could not really locate the cause of this behavior. Thus, I turned off the plotting during the testing for now, and let's fix it afterward.

@yunjunz yunjunz changed the title Update HyP3 full SLC sample data update HyP3 example dataset: RidgecrestSenDT71 Apr 23, 2024
@yunjunz yunjunz changed the title update HyP3 example dataset: RidgecrestSenDT71 update HyP3 example dataset RidgecrestSenDT71 Apr 23, 2024
@yunjunz yunjunz merged commit 3ebf6c6 into main Apr 23, 2024
7 of 8 checks passed
@yunjunz yunjunz deleted the dir_structure branch April 25, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants