Enable quoting for Snowflake #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montanalow
approved these changes
Mar 5, 2019
|
Do you want to bump the version for a patch release? |
|
What's the right thing to do here? Should I be merging into the current production version or the release candidate? |
|
To back port into 0.6 branch with new patch version, you can merge there. Then we can merge 0.6 into master, and cut a new 0.7.0rc if that is the version you're running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Enable quoting of fields when bulk uploading to Snowflake
Why
Bulk upload fails when a field contains the pipe character.
Note: This version is not exposing the quote character as an argument. The reason for that is
psycopg2does not have support for the quote character without the use ofcopy_expert. As a result, this PR went with the choice of not exposing the parameter at all. Certainly open to suggestions here.