Kafka cluster CRD spec was updated with Kraft field #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengu-alt
requested review from
RostislavPorohnya,
ribaraka,
testisnullus,
OleksiienkoMykyta and
worryg0d
Closed
tengu-alt
force-pushed
the
kafka-spec-updating-by-kraft
branch
from
2804472
to
02d3399
Compare
testisnullus
requested changes
Aug 22, 2023
pkg/models/errors.go
Outdated
| @@ -33,6 +35,7 @@ var ( | |||
| ErrTypeAssertion = errors.New("unable to assert type") | |||
| ErrImmutableSchemaRegistry = errors.New("schema registry is immutable") | |||
| ErrImmutableRestProxy = errors.New("rest proxy is immutable") | |||
| ErrImmutableKraft = errors.New("Kraft is immutable") | |||
pkg/models/errors.go
Outdated
| @@ -20,6 +20,8 @@ import "errors" | |||
|
|
|||
| var ( | |||
| ErrZeroDataCentres = errors.New("cluster spec doesn't have data centres") | |||
| ErrMoreThanOneKraft = errors.New("cluster spec spec does not support more than one Kraft") | |||
| ErrMoreThanThreeControllerNodeCount = errors.New("Kraft does not support more than three controller nodes") | |||
worryg0d
reviewed
Aug 22, 2023
pkg/models/kafka_apiv2.go
Outdated
| @@ -34,6 +34,7 @@ type KafkaCluster struct { | |||
| DedicatedZookeeper []*DedicatedZookeeper `json:"dedicatedZookeeper"` | |||
| DefaultNumberOfPartitions int `json:"defaultNumberOfPartitions"` | |||
| DefaultReplicationFactor int `json:"defaultReplicationFactor"` | |||
| Kraft []*Kraft `json:"kraft"` | |||
There was a problem hiding this comment.
Suggested change
| Kraft []*Kraft `json:"kraft"` | |
| Kraft []*Kraft `json:"kraft,omitempty"` |
tengu-alt
force-pushed
the
kafka-spec-updating-by-kraft
branch
3 times, most recently
from
62f9e21
to
ef36f0d
Compare
ribaraka
approved these changes
Aug 23, 2023
pkg/models/errors.go
Outdated
| @@ -20,6 +20,8 @@ import "errors" | |||
|
|
|||
| var ( | |||
| ErrZeroDataCentres = errors.New("cluster spec doesn't have data centres") | |||
| ErrMoreThanOneKraft = errors.New("cluster spec spec does not support more than one kraft") | |||
tengu-alt
force-pushed
the
kafka-spec-updating-by-kraft
branch
from
ef36f0d
to
1e15396
Compare
testisnullus
approved these changes
Aug 23, 2023
worryg0d
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.