tests for opensearch webhook were implemented #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengu-alt
added
test
tengu-alt
requested review from
ribaraka,
DoodgeMatvey,
testisnullus,
worryg0d and
OleksiienkoMykyta
and removed request for
ribaraka
ribaraka
approved these changes
Jan 29, 2024
tengu-alt
force-pushed
the
opensearch-webhook-tests
branch
4 times, most recently
from
06204ec
to
b67d0f8
Compare
worryg0d
approved these changes
Jan 31, 2024
tengu-alt
force-pushed
the
opensearch-webhook-tests
branch
from
b67d0f8
to
8475d32
Compare
testisnullus
requested changes
Feb 6, 2024
Comment on lines
+224
to
+226
| if *old[0] != *new[0] { | ||
| return models.ErrImmutableIngestNodes | ||
| } |
There was a problem hiding this comment.
Do we validate that only 1 or fewer items can be appended to the IngestNodes array while creation?
There was a problem hiding this comment.
yes, we have a kubebuilder annotation that sets maxItems
Comment on lines
+236
to
+237
| if *old[0] != *new[0] { | ||
| return models.ErrImmutableClusterManagedNodes |
|
|
||
| ctx := context.Background() | ||
|
|
||
| When("apply a OpenSearch manifest", func() { |
Comment on lines
+64
to
+67
| prevStringValue := openSearchManifest.Spec.DataCentres[0].ProviderAccountName | ||
| testOpenSearchManifest.Spec.DataCentres[0].ProviderAccountName = models.DefaultAccountName | ||
| Expect(k8sClient.Create(ctx, &testOpenSearchManifest)).ShouldNot(Succeed()) | ||
| testOpenSearchManifest.Spec.DataCentres[0].ProviderAccountName = prevStringValue |
There was a problem hiding this comment.
Do we plan to add tests for RIYOA accounts?
RIYOA - run in your own account. It means, that customer will run Instaclustr Products using their own AWS/AZURE/GCP accounts.
There was a problem hiding this comment.
this test case is made for ensure that cloudProviderSettings is available only for RIYOA accounts
tengu-alt
force-pushed
the
opensearch-webhook-tests
branch
from
8475d32
to
d7a6e53
Compare
testisnullus
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.