issue-698, Save default user ref for zookeeper #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OleksiienkoMykyta
force-pushed
the
issue-698-Save-default-user-ref-for-zookeeper
branch
2 times, most recently
from
774cbf7
to
209a695
Compare
OleksiienkoMykyta
force-pushed
the
issue-698-Save-default-user-ref-for-zookeeper
branch
from
209a695
to
a20fe3b
Compare
tengu-alt
approved these changes
Feb 15, 2024
worryg0d
approved these changes
Feb 15, 2024
ribaraka
requested changes
Feb 15, 2024
| @@ -45,7 +45,8 @@ type ZookeeperStatus struct { | |||
| // INSERT ADDITIONAL STATUS FIELD - define observed state of cluster | |||
| // Important: Run "make" to regenerate code after modifying this file | |||
|
|
|||
| ClusterStatus `json:",inline"` | |||
| ClusterStatus `json:",inline"` | |||
| DefaultUserSecretRef *Reference `json:"defaultRef,omitempty"` | |||
There was a problem hiding this comment.
name a tag such as defaultUserRef or userRef
There was a problem hiding this comment.
It`s not userRef, so I renamed it to defaultUserSecretRef instead
OleksiienkoMykyta
force-pushed
the
issue-698-Save-default-user-ref-for-zookeeper
branch
from
a20fe3b
to
4c7800c
Compare
ribaraka
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.