Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(text): migrate text component to new fields #590

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chuang8511
Copy link
Member

@chuang8511 chuang8511 commented Aug 13, 2024

Because

  • we update text component

This commit

  • migrate fields to current design

Copy link

linear bot commented Aug 13, 2024

@chuang8511
Copy link
Member Author

Please take a look the migration result
previous.txt
updated.txt

@chuang8511 chuang8511 marked this pull request as draft August 20, 2024 18:22
@chuang8511 chuang8511 marked this pull request as ready for review August 21, 2024 15:02
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 123 lines in your changes missing coverage. Please review.

Project coverage is 5.80%. Comparing base (4c08c50) to head (2cef8ea).
Report is 8 commits behind head on main.

Files Patch % Lines
pkg/db/migration/convert/convert000023/convert.go 0.00% 118 Missing ⚠️
pkg/db/migration/migration.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #590      +/-   ##
========================================
+ Coverage   4.77%   5.80%   +1.02%     
========================================
  Files         60      64       +4     
  Lines      26825   31785    +4960     
========================================
+ Hits        1280    1844     +564     
- Misses     25306   29584    +4278     
- Partials     239     357     +118     
Flag Coverage Δ
unittests 5.80% <0.00%> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chuang8511
Copy link
Member Author

chuang8511 commented Aug 23, 2024

I will rebase it in sprint 43.
but, you still can review it first if you have resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: 🚧 Planned
Development

Successfully merging this pull request may close these issues.

2 participants