Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add support for referencing array indices as strings #714

Merged
merged 1 commit into from
Oct 7, 2024
Merged

chore: add support for referencing array indices as strings #714

merged 1 commit into from
Oct 7, 2024

Conversation

donch1989
Copy link
Member

@donch1989 donch1989 commented Oct 7, 2024 •
edited
Loading

Because

  • We want to use the array index not only for bracket indexing but also as a variable.

This commit

  • Adds support for referencing array indices as strings.
  • Fixes instill-artifact client closing bug.

@linear Linear
Copy link

linear bot commented Oct 7, 2024

INS-5862 [Improvement] Improve iterator with index reference

@donch1989 donch1989 merged commit b0b7868 into main Oct 7, 2024
13 checks passed
@donch1989 donch1989 deleted the huitang/ins-5862-2 branch October 7, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

@jvallesm jvallesm Awaiting requested review from jvallesm jvallesm is a code owner

Assignees
No one assigned
Labels
instill component instill vdp
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donch1989 @droplet-bot