Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: Disable line length lint check #45

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

bjhargrave
Copy link
Contributor

When using markdown tables in qna.yaml files, for example, in a knowledge context as copied from a source knowledge markdown file, the markdown table rows can be quite wide. Often much wider than the current 120 char line length limit. Since a markdown table row cannot be split without breaking the table, we need to disable line length checks to support the use of markdown tables in qna.yaml.

When using markdown tables in qna.yaml files, for example, in a
knowledge context as copied from a source knowledge markdown file,
the markdown table rows can be quite wide. Often much wider than the
current 120 char line length limit. Since a markdown table row cannot
be split without breaking the table, we need to disable line length
checks to support the use of markdown tables in qna.yaml.

Signed-off-by: BJ Hargrave <[email protected]>
Copy link

@juliadenham juliadenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjhargrave bjhargrave merged commit a049a4d into instructlab:main Aug 22, 2024
12 checks passed
@bjhargrave bjhargrave deleted the yamllint-no-line-length branch August 22, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants