Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

194: Improve responsive behavior of Header and Side Navigation Bar #237

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

ediazgallego
Copy link
Collaborator

Why

  • The header and left sidebar of the application are not responsive, causing layout issues and reduced usability on smaller window sizes and mobile devices

What

  • Update Patternfly components to make use of the built-in responsive capabilities for header and sidebar.

Screenshots

Screen.Recording.2024-10-03.at.8.49.01.AM.mov

@ediazgallego ediazgallego added the enhancement New feature or request label Oct 3, 2024
@ediazgallego ediazgallego added this to the release-1.1 milestone Oct 3, 2024
@ediazgallego ediazgallego linked an issue Oct 3, 2024 that may be closed by this pull request
@ediazgallego ediazgallego added the bug Something isn't working label Oct 3, 2024
Copy link
Member

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnoianil
Copy link
Member

@ediazgallego can you please cherry-pick this commit to release-1.0 branch and open a pr against release-1.0 branch?

@ediazgallego
Copy link
Collaborator Author

@ediazgallego can you please cherry-pick this commit to release-1.0 branch and open a pr against release-1.0 branch?

@vishnoianil here is the PR to get this into release-1.0

@vishnoianil vishnoianil merged commit b5f5281 into instructlab:main Oct 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve responsive behavior of Header and Side Navigation Bar
2 participants