Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/#28/description for skill and knowledge #38

Conversation

aevo98765
Copy link
Member

Attempting to address #28.

Very open to both feedback and making changes.

@aevo98765 aevo98765 force-pushed the issue/#28/description-for-skill-and-knowledge branch from d86eea3 to 4d149b8 Compare July 3, 2024 12:35
@aevo98765 aevo98765 force-pushed the issue/#28/description-for-skill-and-knowledge branch from f1fcbcf to 1fb1356 Compare July 3, 2024 12:59
@nerdalert
Copy link
Member

@aevo98765 Looks awesome, would you mind squashing a couple of the commits for the git log (draft, linting) before we merge it? Ty!

@aevo98765 aevo98765 force-pushed the issue/#28/description-for-skill-and-knowledge branch from 1fb1356 to 7dbda5a Compare July 7, 2024 23:08
@aevo98765
Copy link
Member Author

How does this look now @nerdalert?

Copy link
Member

@nerdalert nerdalert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aevo98765 awesome. LGTM

@nerdalert nerdalert merged commit 9afb8d0 into instructlab:main Jul 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants