-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calendar View SwiftUI Rebuild #2903
base: master
Are you sure you want to change the base?
Conversation
❌ Swift lint
|
refs: - affects: Student,Teacher release note: .. test plan: See PR description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice job in overall! I noticed that we miss the feature of swiping left and right on the events list, this should change to the next or previous date on the calendar (and triggering month / week switch animation if necessary).
I also noticed this more serious animation glitch when collapsing a month other than the current one:
https://github.com/user-attachments/assets/056d901c-c836-4543-a323-8811283ec698
We need some code cleanup but I think it's in a pretty good shape to be merged.
# Conflicts: # Core/Core/ObserverAlerts/GetObserverAlerts.swift
refs: MBL-17890 affects: Student, Teacher, Parent release note: none test plan:
… TestsFoundation projects.
- Update projects to recommended settings. - Add reverse relationship to Quiz
Screenshots
Checklist