Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar View SwiftUI Rebuild #2903

Draft
wants to merge 40 commits into
base: master
Choose a base branch
from

Conversation

suhaibabsi-inst
Copy link
Contributor

Screenshots

BeforeAfter

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

@suhaibabsi-inst suhaibabsi-inst changed the base branch from master to bugfix/Xcode16-Fixes September 29, 2024 22:56
@inst-danger
Copy link
Contributor

inst-danger commented Sep 29, 2024

Fails
🚫 Build failed, skipping coverage check
❌ Swift lint
----- xcbeautify -----
Version: 2.11.0
----------------------

❌ /Users/vagrant/git/Core/Core/Planner/CalendarMain/Model/CalendarMonth.swift:61:1: Trailing Whitespace Violation: Lines should not have trailing whitespace (trailing_whitespace)
/Users/vagrant/git/Core/Core/Planner/CalendarMain/View/Calendar/CalendarUtils.swift:65:1: error: Trailing Whitespace Violation: Lines should not have trailing whitespace (trailing_whitespace)

Generated by 🚫 dangerJS against b496e39

@suhaibabsi-inst suhaibabsi-inst self-assigned this Sep 30, 2024
Copy link
Contributor

@vargaat vargaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job in overall! I noticed that we miss the feature of swiping left and right on the events list, this should change to the next or previous date on the calendar (and triggering month / week switch animation if necessary).
I also noticed this more serious animation glitch when collapsing a month other than the current one:
https://github.com/user-attachments/assets/056d901c-c836-4543-a323-8811283ec698

We need some code cleanup but I think it's in a pretty good shape to be merged.

Base automatically changed from bugfix/Xcode16-Fixes to master October 24, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants