Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Results Screen - Highlight Searched Words #2944

Draft
wants to merge 11 commits into
base: feature/MBL-17906-Course-Smart-Search
Choose a base branch
from

Conversation

suhaibabsi-inst
Copy link
Contributor

refs: MBL-18009
affects: Student
release note: Course Smart Search Results with Highlighted Searched Words

test plan: See PR description

Screenshots

BeforeAfter

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

refs: MBL-17907,MBL-17906,MBL-17905,MBL-17904,MBL-17903,MBL-17902
affects: Student
release note: Courses Smart Search Experience for Student

test plan: See PR description
refs: MBL-18009
affects: Student
release note: Course Smart Search Results with Highlighted Searched Words

test plan: See PR description
@inst-danger
Copy link
Contributor

inst-danger commented Oct 20, 2024

Fails
🚫 Build failed, skipping coverage check

Release Note:

Course Smart Search Results with Highlighted Searched Words

Affected Apps: Student

MBL-18009

❌ Swift lint
❌ /Users/vagrant/git/Core/Core/Search/Views/KeywordHighlightingText.swift:92:1: Line Length Violation: Line should be 200 characters or less; currently it has 388 characters (line_length)
/Users/vagrant/git/Core/Core/Search/Views/KeywordHighlightingText.swift:91:1: error: Superfluous Disable Command Violation: SwiftLint rule 'line_length' did not trigger a violation in the disabled region; remove the disable command (superfluous_disable_command)

Generated by 🚫 dangerJS against 233de2d

@suhaibabsi-inst suhaibabsi-inst force-pushed the feature/MBL-17906-Course-Smart-Search branch from 28dc665 to 6420478 Compare October 22, 2024 08:50
@suhaibabsi-inst suhaibabsi-inst self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants