WIP(ui-dom-utils): update findFocusable logic

instructure · Jul 21, 2023 · 01e4ef8 · 01e4ef8
1 parent 1732297
commit 01e4ef8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/packages/ui-dom-utils/src/__tests__/findTabbable.test.tsx b/packages/ui-dom-utils/src/__tests__/findTabbable.test.tsx
@@ -43,9 +43,6 @@ describe('findTabbable', async () => {
             <button>Yep</button>
             <button style={{ display: 'none' }}>Nope</button>
           </div>
-          <div style={{ width: 0, height: 0 }}>
-            <button>Nope</button>
-          </div>
         </div>
       )
       /* eslint-enable jsx-a11y/no-noninteractive-tabindex */

diff --git a/packages/ui-dom-utils/src/findFocusable.ts b/packages/ui-dom-utils/src/findFocusable.ts
@@ -83,12 +83,7 @@ function findFocusable(
 
 function hidden(element: Element | Node) {
   const cs = getComputedStyle(element)
-  return (
-    (cs.display !== 'inline' &&
-      (element as HTMLElement).offsetWidth <= 0 &&
-      (element as HTMLElement).offsetHeight <= 0) ||
-    cs.display === 'none'
-  )
+  return cs.display === 'none'
 }
 
 function positioned(element: Element | Node) {