fix(ui-date-input): fix DateInput2 to update messages properly

instructure · Oct 31, 2024 · 553a235 · 553a235
1 parent cc742d1
commit 553a235
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/ui-date-input/src/DateInput2/index.tsx b/packages/ui-date-input/src/DateInput2/index.tsx
@@ -184,9 +184,9 @@ const DateInput2 = ({
 
   useEffect(() => {
     // don't set input messages if there is an internal error set already
-    if (!inputMessages.length && !invalidDateErrorMessage) {
-      setInputMessages(messages || [])
-    }
+    if (inputMessages.find((m) => m.text === invalidDateErrorMessage)) return
+
+    setInputMessages(messages || [])
   }, [messages])
 
   useEffect(() => {

diff --git a/packages/ui-date-input/src/index.ts b/packages/ui-date-input/src/index.ts
@@ -25,3 +25,4 @@
 export { DateInput } from './DateInput'
 export { DateInput2 } from './DateInput2'
 export type { DateInputProps } from './DateInput/props'
+export type { DateInput2Props } from './DateInput2/props'