Skip to content

Commit

Permalink
refactor(ui-table,ui-tag): remove not needed eslint-disable
Browse files Browse the repository at this point in the history
  • Loading branch information
matyasf authored and ToMESSKa committed Aug 30, 2024
1 parent 20011fb commit acbd40c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
4 changes: 0 additions & 4 deletions packages/ui-table/src/Table/__new-tests__/Table.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ import type { TableProps } from '../props'
import type { TableColHeaderProps } from '../ColHeader/props'
import { runAxeCheck } from '@instructure/ui-axe-check'

// see https://github.com/vitest-dev/eslint-plugin-vitest/issues/511
// eslint-disable-next-line vitest/valid-describe-callback
describe('<Table />', async () => {
let consoleErrorMock: MockInstance<typeof console.error>

Expand Down Expand Up @@ -208,8 +206,6 @@ describe('<Table />', async () => {
expect(table).toHaveTextContent('Foo')
})

// see https://github.com/vitest-dev/eslint-plugin-vitest/issues/511
// eslint-disable-next-line vitest/valid-describe-callback
describe('when table is sortable', async () => {
const renderSortableTable = (
props: TableColHeaderProps | null,
Expand Down
4 changes: 0 additions & 4 deletions packages/ui-tag/src/Tag/__new-tests__/Tag.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ import { View } from '@instructure/ui-view'

const originalOmitViewProps = View.omitViewProps

// https://github.com/vitest-dev/eslint-plugin-vitest/issues/511
// eslint-disable-next-line vitest/valid-describe-callback
describe('<Tag />', async () => {
beforeAll(() => {
// View component read Component.name instead of Component.displayName
Expand Down Expand Up @@ -95,8 +93,6 @@ describe('<Tag />', async () => {
expect(axeCheck).toBe(true)
})

// https://github.com/vitest-dev/eslint-plugin-vitest/issues/511
// eslint-disable-next-line vitest/valid-describe-callback
describe('when passing down props to View', async () => {
const allowedProps: Partial<ViewProps> = {
margin: 'small',
Expand Down

0 comments on commit acbd40c

Please sign in to comment.