docs(ui-menu): target prop support for MenuItem

instructure · Aug 7, 2024 · bb031b3 · bb031b3
1 parent 8c61905
commit bb031b3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/packages/ui-menu/src/Menu/MenuItem/props.ts b/packages/ui-menu/src/Menu/MenuItem/props.ts
@@ -88,6 +88,10 @@ type MenuItemOwnProps = {
    * Value of the `href` prop that will be put on the underlying DOM element.
    */
   href?: string
+  /**
+   * Where to display the linked URL, as the name for a browsing context (a tab, window, or <iframe>).
+   */
+  target?: string
 }
 
 type PropKeys = keyof MenuItemOwnProps
@@ -115,7 +119,8 @@ const propTypes: PropValidators<PropKeys> = {
   as: PropTypes.elementType, // eslint-disable-line react/require-default-props
   type: PropTypes.oneOf(['button', 'checkbox', 'radio', 'flyout']),
   value: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
-  href: PropTypes.string
+  href: PropTypes.string,
+  target: PropTypes.string,
 }
 
 const allowedProps: AllowedPropKeys = [
@@ -132,7 +137,8 @@ const allowedProps: AllowedPropKeys = [
   'as',
   'type',
   'value',
-  'href'
+  'href',
+  'target'
 ]
 type MenuItemState = {
   selected: boolean

diff --git a/packages/ui-menu/src/Menu/README.md b/packages/ui-menu/src/Menu/README.md
@@ -53,7 +53,7 @@ class Example extends React.Component {
         mountNode={() => document.getElementById('main')}
       >
         <Menu.Item value="mastery">Learning Mastery</Menu.Item>
-        <Menu.Item href="https://instructure.github.io/instructure-ui/">Default (Grid view)</Menu.Item>
+        <Menu.Item href="https://instructure.github.io/instructure-ui/" target="_blank">Default (Grid view)</Menu.Item>
         <Menu.Item disabled>Individual (List view)</Menu.Item>
         <Menu label="More Options">
           <Menu.Group